[CORE-69] Fix checkout action #114
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 60c9669 | Previous: 7b4ef46 | Ratio |
|---|---|---|---|
bio.terra.pfb.LibraryBenchmarks.showNodesMedium |
1496.4810979331457 ops/s |
1474.536611860186 ops/s |
1.01 |
bio.terra.pfb.LibraryBenchmarks.showNodesSmall |
21993.2580899804 ops/s |
21914.329551949566 ops/s |
1.00 |
bio.terra.pfb.PfbReaderBenchmarks.convertEnum |
5392083.769351286 ops/s |
5259104.629983816 ops/s |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
jgainerdewar
approved these changes
Nov 24, 2025
Contributor
Author
|
The problem was on github's side, not mine. actions/checkout@v6 now works as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#112 updated actions/checkout to v6, but that apparently fails when applied with a
ref- which is only used in the publish-library job, so the pre-merging tests all passed. I'm not positive what the problem is; copilot reports "The error occurs because actions/checkout@v6 changed how it handles the ref input. In v6, if you provide a tag (like 0.89.0) to ref, it tries to fetch both the branch and tag named 0.89.0, but only the tag exists. This causes the fetch to fail." although I failed to see that discussed in the release notes . So this PR attempts to update how the ref is handled; running just the publish job got past the checkout stage (and failed because the supplied tag already existed in the library).